Abdelrazak Younes wrote:
Concerning your QMAction class, I think we could merge it with my QLAction class. But this would maybe mean touching the controller... food for thought.

i created QMAction because i didn't want (or didn't know how) to pass a lyxview to an object in QMathDialog.

but i recognize that it is not very nice to have a lot of specializations floating around.

it also seems like we are putting layer over identical layer:

                             )
                            (_)
                           +-'-+
                           |   |
                           |   |
                           |   |
                           |   |
===========================================================

connect(ma, SIGNAL(action(const std::string &)), this, SLOT(symbol_clicked(const std::string &)));

============================================================

void QMathDialog::symbol_clicked(const string & str)
{
        form_->controller().dispatchInsert(str);
}

============================================================

void ControlMath::dispatchInsert(string const & name) const
{
        dispatchFunc(LFUN_INSERT_MATH, '\\' + name);
}

============================================================

dispatchFunc(LFUN_INSERT_MATH, '\\' + name);

============================================================


i guess the frontend is the icing on the lyx-cake ;-)

Reply via email to