Re: [Qt4 bug] Branches dialog, small issue with "alter color"

[Abdelrazak Younes]

Abdelrazak Younes a écrit :

Abdelrazak Younes a écrit :

Here is the first bug:

When you click the "Alter button" on a added branch in "Document Settings/Branches" Dialog, clicking on the palette on the right to select a color won't work (selected color stays black). After selecting a color from the "Basic Colors" or the "Custon colors" (which works fine), the color selection from the palette will work correctly. The bug relies most surely in QBranches::on_colorPB_clicked() and more exactly on the QColorDialog call.

And here is the fix. The problems lies in that the QColor() constructor produces an invalid color (RGB 0,0,0). I am going to commit that for qt4. This bug is also present in qt2 but I am not sure the same fix applies. I have chosen "lightskyblue" as the default color for a branch. Is it OK?

Here is the fix to qt2, I will not commit this because I haven't tested it.

Abdel.

Index: D:/msys/home/yns/lyx/trunk/src/frontends/qt2/QDocumentDialog.C
===================================================================
--- D:/msys/home/yns/lyx/trunk/src/frontends/qt2/QDocumentDialog.C      
(revision 13409)
+++ D:/msys/home/yns/lyx/trunk/src/frontends/qt2/QDocumentDialog.C      
(working copy)
@@ -503,7 +503,7 @@
        if (selItem != 0)
                sel_branch = selItem->text(0);
        if (sel_branch) {
-               QColor initial;
+               QColor initial("lightskyblue");
                string current_branch = fromqstr(sel_branch);
                Branch * branch =
                        form_->branchlist_.find(current_branch);