Jean-Marc Lasgouttes wrote:

> If we need a default branch color, it should be a new member of
> LColor.

I had a look at the code, and LColor::background is used for display if a
branch has no color. We should make that explicit and set it in the
constructor IMHO, then all the checks for a valid color would not be needed
anymore.

One problem I see with using a LColor for branches is that it is currently
possible to use an arbitrary color, specified by r, g, and b. How would we
do that with LColor? Adding a new color everytime the user chooses a new
branch color? How would we get the rgb values for the existing colors, e.g.
LColor::background?


Georg

Reply via email to