Hello Andre,
I noticed that your mails seem to arrive with a delay of one or two
days. Maybe your clock settings are wrong or something?
Andre Poenitz a écrit :
On Wed, Mar 08, 2006 at 04:28:30PM +0100, Abdelrazak Younes wrote:
It shouldn't be much of a difference, but the canonical way for
such a 'symmetric' operation is to have it as free function outside the
class.
I know but in this case (template class), it is much less code inside
the class.
I am not sure there are many precedence for capitalized member variables
in LyX code.
There are some from which I took example... I think you guys should
agree on coding style guidelines and write a _small_ document with it.
Second step would be to actually use it all through the code ;-)
RandomAccessList(It it_start, It it_end) {
Maybe adding 'reserve' is in order.
OK.
'swap' would be nice to have in the long run...
Yes.
bool erase(iterator start, iterator end) {
size_t startpos = std::distance(Container_.begin(),
static_cast<base_it>(start));
size_t endpos = std::distance(Container_.begin(),
static_cast<base_it>(end));
return erase(startpos, endpos-startpos);
}
const + spacing.
const?
Could you move this up a bit closer to the constructors?
Sure.
Look pretty good in general.
Thanks for the comments Andre. One question about the spacing: is it
because of your editor or just that you find it easier to read?
Abdel.
