On Sat, Mar 11, 2006 at 09:03:22AM +0100, Abdelrazak Younes wrote:
> Hello Andre,
Hello Abdel.
> I noticed that your mails seem to arrive with a delay of one or two
> days. Maybe your clock settings are wrong or something?
No, it just means I am rarely online and am usually not connected to the
net when I write mail.
> Andre Poenitz a écrit :
> >On Wed, Mar 08, 2006 at 04:28:30PM +0100, Abdelrazak Younes wrote:
> >
> >It shouldn't be much of a difference, but the canonical way for
> >such a 'symmetric' operation is to have it as free function outside the
> >class.
>
> I know but in this case (template class), it is much less code inside
> the class.
I am fine with that as long as you find a reason...
> >I am not sure there are many precedence for capitalized member variables
> >in LyX code.
>
> There are some from which I took example... I think you guys should
> agree on coding style guidelines and write a _small_ document with it.
> Second step would be to actually use it all through the code ;-)
Ugh...
>
> >> RandomAccessList(It it_start, It it_end) {
> >
> >Maybe adding 'reserve' is in order.
>
> OK.
>
> >
> >'swap' would be nice to have in the long run...
>
> Yes.
>
> >> bool erase(iterator start, iterator end) {
> >> size_t startpos = std::distance(Container_.begin(),
> >> static_cast<base_it>(start));
> >> size_t endpos = std::distance(Container_.begin(),
> >> static_cast<base_it>(end));
> >> return erase(startpos, endpos-startpos);
> >> }
> >
> >const + spacing.
>
> const?
bool erase(iterator start, iterator end) {
size_t const startpos = std::distance(Container_.begin(),
static_cast<base_it>(start));
size_t const endpos = std::distance(Container_.begin(),
static_cast<base_it>(end));
> >Could you move this up a bit closer to the constructors?
>
> Sure.
>
> >
> >Look pretty good in general.
>
> Thanks for the comments Andre. One question about the spacing: is it
> because of your editor or just that you find it easier to read?
Spacing? Well, it's nowadays fairly consistent within LyX.
I usually don't care too much about a certain style as long as it is
used consistently within a project. But when given a choice, I tend to
prfer the 'spacey style' for private stuff (except for shell and
Makefiles...)
Andre'
