Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes a écrit : | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | Index: | > D:/msys/home/yns/src/lyx-svn/trunk/src/frontends/qt4/QLMenubar.h | > | =================================================================== | > | --- D:/msys/home/yns/src/lyx-svn/trunk/src/frontends/qt4/QLMenubar.h (revision 13312) | > | +++ D:/msys/home/yns/src/lyx-svn/trunk/src/frontends/qt4/QLMenubar.h (working copy) | > | @@ -15,7 +15,11 @@ | > | | #include "frontends/Menubar.h" | > | | -#include <map> | > | +#include <map> | > | + | > | +#ifdef Q_WS_MACX | > | +#include <boost/scoped_ptr.hpp> | > | +#endif | > Wh is the ifdef needed? Does something bad happens if it is left out? | | No it's just that the include is not needed otherwise. I thought that it | was a general rule for LyX code but if you don't mind, I prefer to | remove them... I am not really fond of #ifdef.
I really dislike ifdef as well. Other solutions should be sought after. | I would also get rid of | the one around menubar_ at the end: | | #ifdef Q_WS_MACX | boost::scoped_ptr<QMenuBar> menubar_; | #endif Why is menubar_ needed on mac and not otherwise? -- Lgb