>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> No it's just that the include is not needed otherwise. I Abdelrazak> thought that it was a general rule for LyX code but if you Abdelrazak> don't mind, I prefer to remove them... I am not really Abdelrazak> fond of #ifdef. I would also get rid of the one around Abdelrazak> menubar_ at the end: Abdelrazak> #ifdef Q_WS_MACX boost::scoped_ptr<QMenuBar> menubar_; Abdelrazak> #endif Abdelrazak> I 'll send a new patch that gets rid of the #ifdef. I did not notice it was this one. This scoped_ptr is only defined on the mac, because of the global toolbar on the mac. I have to admit it is a weird hack :) Note that the code that uses this menubar_ is in a ifdef (and should remain like that probably). So you are defining a variable that is only useful in Qt/Mac. You should indicate it in a comment. JMarc
