Martin Vermeer wrote:
> > 1. Undo oddities:
> >
> > (a) Cut ... paste ... undo works well for undoing the paste; however,  
> > undoing again to undo the cut results in the cursor appearing in  
> > front of the text that was restored; it should be after it.

could you sketch a scenario? I couldn't reproduce this (without the patch).

> > (b) Typing text and then selecting Undo will undo the typing of only  
> > a single character at a time. (I'm not sure if this is related to  
> > this patch.)
>
> I don't really see how cit could be.

It isn't. This is also without your patch. Normally, LyXText::InsertChar() 
uses Undo::INSERT (adding everything to one stack) and calls finishUndo() 
every 20 chars [1] (i.e. this is what charInserted() does).
So there must be a superfluous finishUndo() call somewhere in the chain.

Jürgen

[1] which I find a bit arbitrary for a word processor. I would expect the 
grouping of words, like OOo does, that is, call finishUndo() when a space has 
been inserted.

Reply via email to