Jean-Marc Lasgouttes wrote:
> Angus> Just for completeness, here are patches that I believe will
> Angus> allow tex2lyx to run successfully on Win95 and Win98 and will
> Angus> allow both LyX 1.3.x and LyX 1.4.x to be used as a conversion
> Angus> filter on such machines. (It's likely that Qt/WinFree will die
> Angus> a horrible death though...)
> It looks much better. Two remarks (that you can freely ignore if you
> want):
> 1/ it is not necessary to expose GetLongPath in os_win32.h, since this
> is internal to os_win32.C.
Sure. But I'll leave that as it makes the code easier to read.
> 1a/ the first comment in this class definition is bogus:
> +/** This class provides a portable wrapper to SHGetFolderPathA that can
> be
Good. s/SHGetFolderPathA/GetLongPathNameA/
> 2/ I am not sure why you need the global win32_folder_path pointer. Is
> it some kind of optimization?
I think I had a little bit of a brain storm when I first wrote the code,
six weeks ago :) The optimization is totally unnecessary. I'll get rid of
the pointer and change get_document_dir, so. Similarly for the code to
grab the Application Data path.
<shrug>
We load and unload shfolder.dll twice, but so what?
<\shrug>
string const get_document_dir(string const & home_dir)
{
#if defined (USE_WINDOWS_PACKAGING)
(void)home_dir; // Silence warning about unused variable.
- return win32_folder_path(CSIDL_PERSONAL);
+ GetFolderPath win32_folder_path;
+ return win32_folder_path(GetFolderPath::PERSONAL);
#else // Posix-like.
return home_dir;
#endif
}
--
Angus
