Jean-Marc Lasgouttes wrote:
>>> What about changing "lyx" to "LyX" in PACKAGE? This will work with
>>> version suffix stuff.
>
> Bennett> That would be great.
>
> OK, here are two patches:
>
> lyxosx.diff changes lyx to LyX in PACKAGE only for the determination
> of the use directory. It is the least intrusive solution.
>
> lyxosx-config.diff changes the PACKAGE variable in configure itself
> (you need to run autogen.sh). Many things will be changed (binary
> name, ...).
>
> Could you test those two approaches? Which one is the best?
>
> Angus, do you think we should do the same (at least the first one) to
> Windows?
PACKAGE is hardcoded in config.h. Eg "lyx" or "lyx-1.3.6cvs". If people
specify PACKAGE as something other than "lyx", then shouldn't their choice
be respected?
@@ -608,7 +608,8 @@ string const get_default_user_support_di
if (status_code != 0)
return string();
- return AddPath(reinterpret_cast<char const *>(store), PACKAGE);
+ return AddPath(reinterpret_cast<char const *>(store),
+ subst(PACKAGE, "lyx", "LyX");
Perhaps this code should be:
string const user_dir = (PACKAGE == "lyx") ? "LyX" : PACKAGE;
return AddPath(reinterpret_cast<char const *>(store), user_dir);
I don't know how important this is. Basically, I'm just thinking out
aloud...
--
Angus
