Martin Vermeer wrote:

> That's what you get when an inset such as insetvspace has a doDispatch but
> no matching getStatus...

getStatus should not be needed in this case, since InsetBase handles
LFUN_INSET_MODIFY. However, it expects an argument:

case LFUN_INSET_MODIFY:
        // Only allow modification of our own data.
        // This needs to be handled in the doDispatch method of our
        // instantiatable children.
        if (lyxCode() == translate(cmd.getArg(0))) {
                flag.enabled(true);
                return true;
        }
        return false;


Question to our lfun experts: Why is LFUN_INSET_MODIFY sometimes used with
argument and sometimes not? Should we relax the check in InsetBase, or add
InsetVSpace::getStatus?

> Just add one. Surely this is not the only one.

I checked all insets last week, and they should all handle LFUN_INSET_MODIFY
themselves or by inheritance.


Georg

Reply via email to