Georg Baum wrote:
>> Angus> However, I wonder if it would not be nicer to have:
>> [a getLFUN method]
> 
> Yes.
> 
>> Agreed. Also, I'd rather have a signature like
>> virtual FuncStatus getStatus() const;
>> since it is more in line with what LyXFunc does.
> 
> Yes, but we need only the boolean value here. Things like
> 
> virtual bool getStatus() const { return true; }
> 
> in ControlChanges.h would become more complicated, and we would need to
> include FuncStatus.h in Dialog.h. Therefore I want to keep the current
> signature.
> I am going to apply the attached patch

In the ChangeLog and in Dialog.[Ch]: s/wether/whether/

Other than that, it looks/feels good.

-- 
Angus

Reply via email to