>>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:

>> Agreed. Also, I'd rather have a signature like virtual FuncStatus
>> getStatus() const; since it is more in line with what LyXFunc does.

Georg> Yes, but we need only the boolean value here. Things like

Georg> virtual bool getStatus() const { return true; }

Georg> in ControlChanges.h would become more complicated, 

Not with Angus getLFun idea.

Georg> and we would need to include FuncStatus.h in Dialog.h.
Georg> Therefore I want to keep the current signature. I am going to
Georg> apply the attached patch unless you insist on the FuncStatus
Georg> version.

I do not insist, but I will probably feel the urge to change it in a
year or two :)

OK, something that would please me is to change the name of the method
from getStatus() to something like canApply() or whatever. This way
we would avoid to reuse a name with different semantics.

JMarc

Reply via email to