>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:

Angus> Mmmm, but the ISpell class encapsulates our interaction with
Angus> the external ispell process. Not being able to interact with
Angus> this external process (no select(), different API to open
Angus> pipes) is conceptually the same to the rest of LyX as being
Angus> unable to launch the ispell process. In both cases all that
Angus> matters is that ISpell tells the caller that we failed to
Angus> launch ispell.

What about turning your dummy ispell implementation into a SpellBase
implementation (that is make it non-working instead of abstract)? Then
ControlSpellCheck would just use a SpellBase instance when the rest
fails. 

Angus> Anyway, here is the patch as it is, implementing stub versions
Angus> of ISpell and of LyXComm. Something similar is needed for
Angus> LyXSocket but I can't remember what the errors were when
Angus> compiling with mingw, so will check again later.

The LyXComm dummy implementation looks good (at least to me).

Concerning the configure stuff, I do not like much checking directly
against cached variables, but the alternative would probably by
uglier.

JMarc

Reply via email to