Jean-Marc Lasgouttes wrote: > Angus> Well, see how you like this, which extends the previous patch > Angus> as you suggest. It leads to the following variables being > Angus> defined in config.h > > The code for lyxserver, lyxsocket.
This isn't a sentence. I take it that you mean you like the code for lyxserver and lyxsocket? > Concerning socktools, I do not understand why you need the makefile > conditional now that you have a proper stub for windows. Fair point. > For the ispell code, I like it too, but I would have defined the stub > implementation in SpellBase.C. I'll do that too. > Finally, for the configure code, I think I'd prefer something like > the attached patch. I only tested that it compiles and runs. I guess > the USE_SOCKTOOLS conditional is unneeded (see above). Very nice! So, you propose that we do not compile the ispell code at all if using aspell or pspell. I guess that we should use these USE_[AIP]SPELL macros when we populate the dropdown list of possible spell checkers in the preferences dialog. What about "hspell" which is available in the Qt frontend but not in the XForms one? -- Angus
