>>>>> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:

Martin> Here is the patch fixing Helge's unfinished macro up/down bug,
Martin> as well as making the cursor move properly for HOME/END. Also
Martin> a slight simplification/dead code removal.

Martin> Unfortunately I didn't get Page Up/Down to behave, so I left
Martin> that part out.

I know I am repeating myself, but we should understand the
LFUN_FINISHED stuff before doing that. Either it makes sense and we
should fix it, or it does not, and we should remove it completely.

The source is full of bugs due to two persons having different idea of
how things are supposed to work and half-implementing it[*]. This is
where we see that we are lacking proper documentation of the kernel.

JMarc

[*] if you want to have fun, try to understand where LyXText::font_
and LyXText::defaultfont_, which are use to resolve against in text2.C
get initialized. Answer: it is never done! One way to solve this is to
nuke all code that refers to them; the other is to know what they were
good for and how to fix them. This used to use outerFont, but it is
now commented out, killing existing functionality.

Reply via email to