Martin Vermeer wrote:
On Thu, Apr 07, 2005 at 03:58:00PM +0200, Jean-Marc Lasgouttes wrote:
"Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes:
Martin> Here is the patch fixing Helge's unfinished macro up/down bug, Martin> as well as making the cursor move properly for HOME/END. Also Martin> a slight simplification/dead code removal.
Martin> Unfortunately I didn't get Page Up/Down to behave, so I left Martin> that part out.
I know I am repeating myself, but we should understand the
LFUN_FINISHED stuff before doing that. Either it makes sense and we
should fix it, or it does not, and we should remove it completely.
This is the part that is unrelated to LFUN_FINISHED: it fixes
Helge's bug and does nothing else. It's a crashing bug and this is the
correct fix IMHO*). Agreed?
This works fine. No more crash when moving out of an unfinished macro. And I just have to like a patch containing "//Make Helge happy" :-) Ideally, the first arrow down/up should move the cursor, not merely close the macro. I guess that is much harder to do? There *is* visual feedback when the macro closes at least.
Helge Hafting
