Andreas Vox wrote:
>> It seems to me that the global 'bool showing' should actually be a
>> one-per-dialog variable.
> ...
>> Do I miss anything?
>>
> The "showing" flag only protects the call to show() itself, therefore it
> should be named "opening".
> The dialog is shown between the call to show() and the subsequent
> hide().
> IMO we don't need machinery to allow a show() inside a show().

Question: do you need to protect the call to "find_or_build"? If not, then 
isn't "showing" equivalent to dialog->isVisible()?

-- 
Angus

Reply via email to