On Mon, 2004-10-25 at 16:39, Josà AbÃlio Oliveira Matos wrote:
> On Mon, Oct 25, 2004 at 04:13:23PM +0300, Martin Vermeer wrote:
> > 
> > At least this looks correct now... but can't you (referring to before
> > this proposed patch) just place the counters thingy *inside* the second
> > if-statement? Again, what do I miss?
> > 
> > Like this
> > 
> >         if (!bstyle->latexparam().empty()) {
> >                 id = bstyle->latexparam();
> >                 if (id.find('#') != string::npos) {
> >                         counters.step(bstyle->counter);
> >                         string el = expandLabel(buf.params().getLyXTextClass(),
> >                                                 bstyle, false);
> >                         id = subst(id, "#", el);
> >                 }
> >         }
> 
>   With this code you are overriding the id even if you don't have any # in
> your style parameter.
> 
>   Then probably the first line inside the if should be instead:
>   
>   id += " " + bstyle->latexparam();

No no... rather, keep it as it is, but shift it to inside the second
if-statement, i.e., one line down.

I still feel you're making this too complicated :-)

-- 
Martin Vermeer <[EMAIL PROTECTED]>

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to