Lars Gullik Bjønnes wrote: > I am not sure that I said that I am going to commit this now... > I mainly want comment on whether to just throw away the patches or > keep the for later.
Having slept on it, I think that my take on these iterators is "lambda or nothing". The code works. It's a bit ugly and using functors means that to understand one loop means scrolling around the document. OTOH, these iterator_adaptors are unfamiliar and the syntax is hardly transparent. I don't see any improvement in legibility. Feel free to disregard entirely ;-) > Ad. the socket io patches -> thos fixed a bug/missing feature as well > as cleaning up code. You'll note, I hope, that I offered only positive feedback on that clean up. I'm not trying to sound purely reactionary, although I realize my tone may be taken as such. FWIW, I'm very glad you've found some time for lyx again. -- Angus
