Lars Gullik Bjønnes wrote:
> Cleaning up my numerous lyx trees I found this.
>
> What where the objections again?
That we're in a freeze? I believe that the general criticism last time
round was that you were just fiddling. Changing working code for the sake
of it. That the new code is neither better nor worse than the old code,
just less familiar.
Maybe things have changed since then.
Personally, I fail to see why this:
- std::sort(bibkeys.begin(), bibkeys.end(), compareNoCase());
is worse than this:
+ // Do a no-case-sensitive sort
+ std::sort(bibkeys.begin(), bibkeys.end(),
+ bind(less<int>(),
+ bind(compare_ascii_no_case, _1, _2),
+ 0));
If you're going to change stuff for the sake of changing it, then at least
change it to something that is immediately understandable. Isn't the
lambda syntax something like:
std::sort(bibkeys.begin(), bibkeys.end(),
lambda::bind(compare_ascii_no_case, _1, _2) < 0);
Ahh well, you're going to do it anyway, so I'll just shut up.
--
Angus
