On Sat, Mar 20, 2004 at 12:29:09PM +0100, Alfredo Braunstein wrote: > <---- s ---------> > blah blah blah blah [open inset] > +----------------+ > | | > | | > > | | > > +----------------+ > blah blah blah blah blah blah blah blah > blah blah blah blah blah blah blah blah > blah blah blah blah blah blah blah blah > > not very optimal, as this uses a lot of unneeded vertical space. (in this > case, I think that display() behaviour is preferable) > > option 2) he uses only w -> we get current cvs behaviour > option 3) use a mixture of the two, choosing the one that spans less > vertical space (the inlined version uses a line less, but then has less > horizontal space to accomodate the remaining rows and so there will be > probably more of them). Probably option 3) is better, but I'm not sure. > Implementing 1) or 3) wouldn't be very hard, only we have to put the > metrics calls for childrens inside the rebreak loop (again, because andre > made some work to take it out...).
That's not a restriction. It seemed naturally to me at some point of time, but if it hampers implementation of a good scheme, we can mangle inset metrics calls and rebreak loop again. [In fact I thought I send a message to the list in this discussion with a similar proposal, but given my current network setup this might as well have ended up on Mars (the European way...)] > A bit messier than the current scheme (make all children metrics call > as a first thing in it's own metrics call) but not terrible. Indeed. > > Now what happens if we have the inset in the first char of an indented line? > > <----------- s -----------> > [open inset] blah blah blah > <--- i ---> > <--------------- w ------------------> > > > 1) doesn't have any problem with this, 2) and 3) have the very same problem > as with minipages. I repeat, making a special casing for the first char of > an indented line is messy and ugly, but I don't see many options. I think we simply ignore this case ('i' is much smaller than 's' and having 95+% minipages is rare...) or pass 's' as textwidth for the inset metrics calls for all insets on the first line in the mangled loop (i.e. solution 3). > 1.3.x didn't have this problem as for instance a float is just > display()ed and so /completely disregards/ indent. Latex does the same > for instance with a 'here, definitely' float. We could ignore the intend in paragraphs with a text inset as first item in all three solutions as well... I would go for 3, i.e. mangle the loop and the metrics call, pass the remaining width as an additional MetricsInfo member, let the inset decide on its width (i.e. either 'tall, but in line' or 'displayed'). WRT the indentation I think I don't care too much. Passing w-i instead of w as textwidth would already help... > Any /constructive/ comment is welcomed. How should I know what qualifies as constructive comment... Andre'