On Mon, Jan 26, 2004 at 09:54:57AM +0000, Angus Leeming wrote:
> Andre Poenitz wrote:
>
> >
> > 1. This dumps most of the rest of the mathcursor implementation into
> > the cursor.[Ch], "globalizes" a bit of them.
>
> How likely is it that the 'non-integrated rest of the original math
> cursor' will be 'generalized for texted'? I guess 'erase', 'up',
> 'down' can all be generalized but that 'macroModeClose' and
> 'handleNest' can't?
In fact, I'd guess we can integrate most of it. Especially I intend to
'globalize' the macro feature, so we'd end up with macro support in
text-ed, too.
> LCursor itself looks like a bit of a bloated monster.
Indeed. This will need a bit of shuffling things around into more
appropriate places. Most notably, the 'interpret' stuff is currently
mathed-centric, so it should go to MathNestInset, or, in case we
'globalize' it, into one of the basic 'priv_dispatch's. It certainly
should not stay in the cursor.
> I thought you didn't 'approve' of my 'wrappers for enums'
> InsetOld_code?
*shrug*
It works ;-)
> Incidentally, shouldn't code like this be InsetBase::LABEL_CODE?
Yes. That's an instance I missed. We will notice this forgotten bits
the hard way as soon as InsetOld dies... No harm done.
> Ie, the inset and the code should both match.
> You've done so in some places but not in others.
>
>
> + InsetBase * inset = par->getInset(0);
> + if (inset->lyxCode() == InsetOld::LABEL_CODE) {
>
> I think you should rearrange the order of the words here so that they
> make a sentence... ;-)
>
> +// We don't really mess want around with mathed stuff outside mathed.
> +// So do it here.
Are you telling me that language of yours makes use of some sort of grammar?
> It's all making a lot of sense.
And a lot of nice crashs. Yeah!
Andre'
