Andre Poenitz wrote:
>
> 1. This dumps most of the rest of the mathcursor implementation into
> the cursor.[Ch], "globalizes" a bit of them.
How likely is it that the 'non-integrated rest of the original math
cursor' will be 'generalized for texted'? I guess 'erase', 'up',
'down' can all be generalized but that 'macroModeClose' and
'handleNest' can't?
LCursor itself looks like a bit of a bloated monster.
I thought you didn't 'approve' of my 'wrappers for enums'
InsetOld_code? Incidentally, shouldn't code like this be
InsetBase::LABEL_CODE? Ie, the inset and the code should both match.
You've done so in some places but not in others.
+ InsetBase * inset = par->getInset(0);
+ if (inset->lyxCode() == InsetOld::LABEL_CODE) {
I think you should rearrange the order of the words here so that they
make a sentence... ;-)
+// We don't really mess want around with mathed stuff outside mathed.
+// So do it here.
+void mathDispatch(LCursor & cur, FuncRequest const & cmd);
It's all making a lot of sense.
--
Angus
