Joao Luis Meloni Assirati wrote:

> 
> Hello again,
> 
> This patch implements Inverse DVI search for lyx. It needs my
> previous patch for the socket lyxserver. To use it, define
> 
>   xdvi -editor 'lyxclient -a $$s -g %f %l'
> 
> as the viewer for the DVI format and
> 
>   latex --src-specials
> 
> as the latex->DVI converter.
> 
> As with the previous, I will provide Changelog entries if this patch
> gets accepted.

João, I am not going to commit this patch as it stands.
I think that you should think about Lars' suggestion to place the 
socket files in ~/.lyx/socket.#pid. Doing so would mean you changing
getBufferFromTmp to getBufferFromPID or similar.

Also note that you can't use the placeholder '$$s' as it is already 
taken (grep '$$s' src/support/filetools.[Ch]).

I think you can regard these as minor points and that we'll expect a 
ChangeLog with the next iteration ;-)

Regards,
-- 
Angus

Reply via email to