Lars Gullik Bj�nnes wrote:
> Please have a look.
I wish you'd get rid of whitespace cruft before asking us to look.,,
Index: po/POTFILES.in
+src/support/path_defines.C
while (true) {
You add it;
I remove it;
}
Could we add a check for whether file.C.in exists before adding
file.C?
> Please have a look.
+ lyxerr[Debug::DEPEND] << itr->first << " CRC... " << flush;
I didn't know that it was possible to flush like that. Very cool!
Index: src/LaTeX.C
Something separate I guess...
Index: src/lyxfunc.C
-void LyXFunc::dispatch(string const & s, bool verbose)
Good!
Index: src/lyxtext.h
- InsetOld::RESULT dispatch(FuncRequest const & cmd);
Does this mean you can remove #include "insets/insetbase.h" from
lyxtext.h?
Index: src/insets/insetbase.h
+protected:
+ // the real dispatcher
+ virtual dispatch_result priv_dispatch
+ (FuncRequest const & cmd, idx_type & idx, pos_type & pos);
Is that the 'standard' naming convention for virtual functions doing
the work of the public interface, non-virtual function? Thanks, I'd
been calling them '_impl'.
Can you not make it private? Which derived class calls priv_dispatch?
None should. They should go through the public interface.
Index: src/insets/insetcollapsable.C
Ok, this somethimes invokes 'dispatch' and sometimes invokes
'priv_dispatch'.
Other than that, it looks good.
Angus
