>>>>> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes:

First I am not sure I see the real interest of the patch. You remove
Paragraph::bibkey, but replace it with Paragraph::bibkey(), which does
not make a big difference. What you remove, though, is the code to
draw the bibkey inset in the margin (so this is a gain), but by what
will you replace it? What is going to make the code less painful?

A few comments:

[stdlists.inc]
+Style Bibliography
+  Margin               Static
+  LatexType            Bib_Environment
+  LatexName            thebibliography
+  NextNoIndent         1
+  LeftMargin           MMN
+  LabelSep             xx
+  ParSkip              0.0
+  ItemSep              0.2
+  TopSep               0.7
+  BottomSep            0.7
+  ParSep               0.3
+  Align                        Block
+  AlignPossible                Block, Left
+  LabelType            Counter_EnumI
+End

Why do you do this, especially since we have the same in
stdstruct.inc?

+       os << "\n\\layout Bibliography\n\\bibitem ";
+       if (! getOptions().empty())
+               os << '[' << getOptions() << ']';

This I really don't like. I hope you have plan to suppress hardcoding
of bibliography layout...

I'd be interested to know what your plans are to make this functional
again after the patch is applied. I understand removing this code
makes averybody feel better, but I'd rather be sure now that we have a
plan for having something right in 1.4.0.

JMarc

Reply via email to