On Mon, Feb 17, 2003 at 03:15:36PM +0000, Angus Leeming wrote:
> Well, since you want people to look at it...
>
> Shouldn't the reading of the inset now go in Buffer::readInset?
Maybe, but bibitems are no "real" insets in the .lyx file, they are
"inlined". Not sure whether that's a case fore readInset() than.
[I thought I better not change the external format...]
> buffer.C: readInset:
> ...
> } else if (cmdName == "bibitem") {
> lex.printError("Wrong place for bibitem");
> inset = new InsetBibKey(inscmd);
Well. I'll have a look later.
> What's going on here in text2.C
> + //if (!par->bibkey()) {
> + if (par->bibkey()) {
> + par->bibkey()->setCounter(number);
> + par->params().labelString(layout->labelstring());
> + }
> + // else {
> + // InsetCommandParams p("bibitem");
> + // par->bibkey() = new InsetBibKey(p);
> + //}
> // In biblio should't be following counters but...
The auto-numbering feature I broke with this patch.
> And what's going on here?
> Index: src/insets/insetbib.h
> ===================================================================
> RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/insets/insetbib.h,v
> retrieving revision 1.48
> diff -u -p -r1.48 insetbib.h
> --- src/insets/insetbib.h 13 Feb 2003 16:53:01 -0000 1.48
> +++ src/insets/insetbib.h 17 Feb 2003 14:51:43 -0000
> @@ -46,9 +46,11 @@ public:
> ///
> EDITABLE editable() const { return IS_EDITABLE; }
> /// A user can't neither insert nor delete this inset
> - bool deletable() const {
> - return false;
> - }
> + //bool deletable() const {
> + // return false;
> + //}
> + /// keep .lyx format compatible
This 'deletable' can be removed entirely now as there is no inset returning
'false' here anymore. I thought I better do that in a second patch.
Andre'
--
Those who desire to give up Freedom in order to gain Security,
will not have, nor do they deserve, either one. (T. Jefferson)
