Richard Geissler wrote:

> During "make install" the directory lyx/xfonts will be created.
> Depending on the umask value of the executing user (e.g. root),
> permissions may be set to something different as they should be (755).
> Therefore I would propose the following change:
> 
> Index: lib/Makefile.am
> ===================================================================
> RCS file: /cvs/lyx/lyx-devel/lib/Makefile.am,v
> retrieving revision 1.50
> diff -r1.50 Makefile.am
> 55a56
>  >       $(CHMOD) 755 $(DESTDIR)$(pkgdatadir)/xfonts ; \
> 
> 
> Regards,
> Richard

Hmmm. Thanks, Richard.

Guys, I note that mkinstalldirs doesn't set the permissions itself and that 
there are two instances in the Makefile where we create dirs:

libinstalldirs:
        for dir in $(LYXLIBDIRS) ; do \
                $(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/$$dir ; \
        done

install-xfonts:
        test -f xfonts/fonts.dir || exit 0 ; \
        $(mkinstalldirs) $(DESTDIR)$(pkgdatadir)/xfonts ; \

Should I add the chmod line for both?

-- 
Angus

Reply via email to