>>>>> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes:

Michael> Hi, please find the current list of compiler warnings below
Michael> (gcc-3.2, xforms frontend). I think a few of them are easily
Michael> fixable.

Michael> xscreen.C: In member function
Michael> `virtual void XScreen::draw(LyXText*, BufferView*, unsigned
Michael> int)': xscreen.C:217: warning: comparison between signed and
Michael> unsigned integer expressions xscreen.C:217: warning:
Michael> comparison between signed and unsigned integer expressions

This one is weird: the code reads

        // is any optimization possible?
        if ((y - old_first) < owner_.workHeight()
            && (old_first - y) < owner_.workHeight())

is there a reason why the test is not

        // is any optimization possible?
        if (std::abs(y - old_first) < owner_.workHeight())

Or maybe the test is not what it intended to be.

Michael> MenuBackend.C: In function `void
Michael> <unnamed>::expandToc(Menu&, const Buffer*)':
Michael> MenuBackend.C:489: warning: unused variable `const
Michael> FloatList&floats' 

Fixed.

Michael> paragraph_pimpl.C: In member function `void
Michael> Paragraph::Pimpl::simpleTeXBlanks(std::ostream&, TexRow&,
Michael> int, int&, const LyXFont&, const LyXLayout&)':
Michael> paragraph_pimpl.C:219: warning: comparison between signed and
Michael> unsigned integer expressions 

Fixed.

Michael> tabular.C: In member function `int LyXTabular::latex(const
Michael> Buffer*, std::ostream&, bool, bool) const': tabular.C:2259:
Michael> warning: enumeration value `LYX_ALIGN_NONE' not handled in
Michael> switch tabular.C:2259: warning: enumeration value
Michael> `LYX_ALIGN_BLOCK' not handled in switch tabular.C:2259:
Michael> warning: enumeration value `LYX_ALIGN_LAYOUT' not handled in
Michael> switch tabular.C:2259: warning: enumeration value
Michael> `LYX_ALIGN_SPECIAL' not handled in switch 

Fixed.

Note that most of the #warnings are not as scary as they seem... (but
of course it would be nice to resolve a few of them).

JMarc

Reply via email to