On Friday 13 December 2002 11:23 am, Andre Poenitz wrote: > On Fri, Dec 13, 2002 at 11:24:45AM +0000, Angus Leeming wrote: > > Having said that, did we come to a consensual view on what version of > > xforms to support in LyX 1.3? I'd prefer to throw out both 0.88 and 0.89. > > The former because it's really old and doesn't have image support. The > > latter because there is no clean separation between 0.88 and 0.89. The > > functionality comes with 0.89.5. It seems ridiculous to have to > > justifying that to a user of 0.89.2 for which no other 0.89 binary was > > released. > > There was pretty much consensus on throwing out 0.88 and not too much > resistance against doing likewise with 0.89. > > > Justifying use of 1.0 can be done on both political as well as practical > > grounds. > > > > Shall I just go ahead and strip the #ifdefs out? > > How much of the cruft would remain if we settle at 0.89.5 as minimum? > > Andre'
1 #ifdef block only and 1 piece of combox.C that should have a #if FL_VERSION < 1 but doesn't. I'll strip all but this block out and we can make a decision about the statement at a later date. Angus $ grep -n "#if" *.[Ch] | sed -n '/FL_/p' FormBase.C:35:#if FL_VERSION > 0 || FL_REVISION >= 89 FormBase.C:173:#if FL_VERSION > 0 || FL_REVISION >= 89 FormBase.C:271:#if FL_VERSION < 1 Menubar_pimpl.C:192:#if FL_VERSION < 1 && FL_REVISION < 89 Tooltips.C:37:#if FL_VERSION > 0 || FL_REVISION >= 89 Tooltips.h:46:#if FL_VERSION < 1 && FL_REVISION < 89 Tooltips.h:78:#if FL_VERSION < 1 && FL_REVISION < 89 XFormsView.C:19:#if FL_VERSION < 1 && (FL_REVISION < 89 || (FL_REVISION == 89 && FL_FIXLEVEL < 5)) XFormsView.C:127:#if FL_VERSION < 1 && (FL_REVISION < 89 || (FL_REVISION == 89 && FL_FIXLEVEL < 5)) XWorkArea.C:24:#if FL_VERSION < 1 && (FL_REVISION < 89 || (FL_REVISION == 89 && FL_FIXLEVEL < 5)) XWorkArea.C:309:#if FL_VERSION < 1 && FL_REVISION < 89 XWorkArea.C:379:#if FL_VERSION < 1 && FL_REVISION < 89 XWorkArea.C:390:#if FL_VERSION < 1 && (FL_REVISION < 89 || (FL_REVISION == 89 && FL_FIXLEVEL < 5)) XWorkArea.C:410:#if FL_VERSION < 1 && (FL_REVISION < 89 || (FL_REVISION == 89 && FL_FIXLEVEL < 5)) XWorkArea.C:491:#if FL_VERSION > 0 || FL_REVISION >= 89 lyx_gui.C:234:#if FL_REVISION < 89 xforms_resize.C:100:#if FL_VERSION > 0 || FL_REVISION > 88 -- Angus
