On Thu, Dec 05, 2002 at 01:56:33PM +0000, Angus Leeming wrote:

> I would of course be happy to change only XWorkArea, but the cursor glyph 
> depends also on whether input is prohibitted or not and /that/ is controlled 
> by LyXView. That, therefore, is the right place to set the glyph and so 
> necessitates going through dispatch.

That *sucks*. Can you get to the workarea widget from the view ? This is
SO a toolkit-only thing, and any LFUN is strictly a very ugly hack.

> I seem to remember a similar conversation with Lars when I proposed the 
> original patch. I took your point of view and he insisted that this be 
> controlled by the core...

I'll take him on :)

> Wait for my patch; I've left you with this in QtView.h ;-)
>       /// FIXME. Not yet implemented.
>       virtual void setCursor(bool editing) const {}

I've already fixed I-beam. I'm not interested in any ugly prohibitInput
thing. For starters, most uses of it are entirely unecessary. Secondly,
the places we really do need it (to avoid pointers changing underneath
the dialog) are just a hack for modality, and should be fixed by making
the dialogs application-modal. Is this not possible in xforms ?

I am less than happy about exposing xforms brokenness in this API.

First we should audit prohibitInputs and remove the unnecessary ones
(there are several). Then we should refactor until qt doesn't have to
see prohibitInput at all.

regards
john
-- 
"Trolls like content too."
        - Bob Abooey, /.

Reply via email to