Angus Leeming <[EMAIL PROTECTED]> writes:

| On Tuesday 03 December 2002 7:24 pm, Lars Gullik Bjønnes wrote:
| > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| > | I did, and am not sure I liked it. This private variable then might
| > | need to be controlled from outside the widget, and that is not good.
| > |
| > | And the scrollbar is not really in the loop (yet).
| > |
| > | *Idea* (have to check this...)
| >
| > This patch makes selection dragging really nice:
| 
| Very clever indeed.  I've tried it out and it works beautifully.
| 
| Nit-pickings: 
| * could you change "timedel" to something a little more expressive.

Hey! timedel is yours.
(or was it timdel?)

Would motion_timeout, or drag_timeout suit you?
(feel free to change it as you please)

| * work_area_handler is currently a static method, so it makes sense to have 
| these static variables. Would things still work if there were multiple 
| work_areas?

njjaaaa.... well yes... as long as you cannot have two persons working
on two workareas at the same time...
But there are some problems there... but nothing has gotten worse as a
result of this patch.

| * assuming that the answer to the above is "yes", why not move 
| motion_interval and timdel into the scope of your FL_DRAG block? Ditto with 
| x_old, y_old and scrollbar_value_old.

That will not really change any "multiple work_areas" problem. But
yes, that could be done.

-- 
        Lgb

Reply via email to