On Mon, Nov 25, 2002 at 12:36:44PM +0100, Jean-Marc Lasgouttes wrote:

> >> You should add an error message at the end of qkey_to_string and
> >> string_to_qkey to find the missng entries and both should rely on a
> >> common table
> 
> John> No, can't work.
> 
> What do you mean? The attached patch adds an error message to
> string_to_qkey and fixes a number of errors found using it. It is
> probably not a good idea to use it as is.

*that's* ok, but you can't add it to the other function.

> John> That neither. Believe me, this stuff is REALLY fubar. And there
> John> is nothing we can do about it. 
> 
> Give me one good reason why a common table cannot be used in both
> functions? 

All [A-Za-z] have to fall through, as there is no Qt::Key_a vs.
Qt::Key_A

If you really think you can fix this stuff nicely, PLEASE do so. I would
be ecstatic. But prepare to be annoyed (and you'll probably need Qt 2
and Qt 3 build to test with ;)

> Yes, but this is not the problem I am trying to solve. My problem is
> in the inaccuracy of the symbols that we are already supposed to
> handle :)

certainly the attached patch looks ok

regards
john

-- 
Khendon's Law: If the same point is made twice by the same person,
the thread is over.

Reply via email to