On Tuesday 05 November 2002 10:31 am, Lars Gullik Bjønnes wrote:
> Angus Leeming <[EMAIL PROTECTED]> writes:
> | Lars, what the fuck have you done to getVectorFromString?
> |
> :-)
>
> The fuctions description is completely bogus then, and behaves
> differently from _all_ similiar functions that I have ever seen.
>
> Delim is used in a really magic way... the function need to be
> renamed and documented properly.
>
> Turn the #if on!
> On second thought, don't! I'd rather go through the sources and fix up
> the cases that expects this behaviour from getVectorFromString.
>
> |     vector<string> const authors = getVectorFromString(author, " and ");
>
> I'd also say that this is misuse of this function.
>
> delim should not be "string to split on" -> use split for that, it is
> "chars to use as delimiters".

<rant>
Don't tell me how to think. I wrote this bloody thing. It does (did) do what 
I wanted. To tell me that my thought process is invalid is just plain rude.
</rant>

Kind regards,
Angus

Reply via email to