Angus Leeming wrote:
>
> But, sure, this is a sample piece of code. You may find this preferable:
> CheckedGlueLength(FL_OBJECT * input,
> FL_OBJECT * choice,
> FL_OBJECT * label=input);
> Ie, the default value for the third arg is the same as the first, so you can
> get away with writing just two.
>
> Or, indeed, this
> CheckedGlueLength(FL_OBJECT * input,
> FL_OBJECT * choice,
> FL_OBJECT * label=0);
>
> although that means you'd have to alter checked_widgets.C a little too.
I prefer to use the "label = input". May I then take it from here and add
new code to your patch in my tree?
One more thing: I can't see why we need the "FL_OBJECT choice" here
and "FL_OBJECT * choice_" in the "class CheckedGlueLength".
Why have you added this?
The choice variables are no where used, so i'm tempted to get
rid of them. All that counts in the isValid check functions, is the
contents of the input field, and label is needed to change its label
color. No need for having the pointers to choice variables here.
Am I right?
If so, shall I remove it. It'll simplify the code slightly; F.ex.
in FormGraphics:
bc().addCheckedWidget(new CheckedGlueLength(file_->input_width));
Thanks,
Rob.
