Hi Jean Marc,
> So, are there any bad bug that you would like to nominate for 1.2.2?
> You can find a list of bugs pending for 1.2.2 at URL
>
>http://bugzilla.lyx.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&&target_milestone=1.2.2
there are a few bugs not listed when you make a query like the one
above; a few new "unconfirmed" bugs might be overlooked (even though I
can confirm that they exist).
#571 #208 #579 #633
In addition, there must be an entry for the following serious bug somewhere:
- Search strings inside math formula are found but not replaced
Another known problem:
- When you change a tgif file on disk, and then update the DVI output,
the graphics is not updated; there should also be a reload button in
the graphics dialog
In addition, there already exists a patch that prints the vertical space
before/after a paragraph explicitly (i.e. in text form). I consider this
very useful but I got no response from others. Just in case anybody has
an opinion on it, you can find the patch attached (against current
1.2.2cvs).
I use LyX for about 4 hours each day. IMHO bug fixing (if anybody is
willing to do it) should concentrate on ironing out the remaining
problems with the new search+replace functionality and fixing the undo
bug. Of course, the infinite table redraw problems are also annoying...
Nevertheless, I am very, very confident with LyX!
Michael
Index: lyx-devel/src/text.C
===================================================================
RCS file: /cvs/lyx/lyx-devel/src/text.C,v
retrieving revision 1.248.2.5
diff -u -r1.248.2.5 text.C
--- lyx-devel/src/text.C 2002/09/10 15:54:44 1.248.2.5
+++ lyx-devel/src/text.C 2002/09/10 18:19:16
@@ -3248,13 +3248,12 @@
int LyXText::getLengthMarkerHeight(BufferView * bv, VSpace const & vsp) const
{
+ if (vsp.kind() == VSpace::NONE)
+ return 0;
+
int const arrow_size = 4;
int const space_size = int(vsp.inPixels(bv));
- if (vsp.kind() != VSpace::LENGTH) {
- return space_size;
- }
-
LyXFont font;
font.decSize();
int const min_size = max(3 * arrow_size,
@@ -3271,6 +3270,9 @@
int LyXText::drawLengthMarker(DrawRowParams & p, string const & prefix,
VSpace const & vsp, int start)
{
+ if (vsp.kind() == VSpace::NONE)
+ return 0;
+
int const arrow_size = 4;
int const size = getLengthMarkerHeight(p.bv, vsp);
int const end = start + size;
@@ -3281,10 +3283,11 @@
int ty1, ty2;
// y-values for bottom arrow
int by1, by2;
+
+ str = prefix + " (" + vsp.asLyXCommand() + ")";
+
switch (vsp.kind()) {
- case VSpace::LENGTH:
- {
- str = prefix + " (" + vsp.asLyXCommand() + ")";
+ case VSpace::LENGTH: {
// adding or removing space
bool const added = !(vsp.length().len().value() < 0.0);
ty1 = added ? (start + arrow_size) : start;
@@ -3293,14 +3296,10 @@
by2 = added ? end : (end - arrow_size);
break;
}
- case VSpace:: VFILL:
- str = prefix + " (vertical fill)";
+ default:
ty1 = ty2 = start;
by1 = by2 = end;
break;
- default:
- // nothing to draw here
- return size;
}
int const leftx = p.xo + leftMargin(p.bv, p.row);
@@ -3321,6 +3320,9 @@
str, font,
backgroundColor(),
backgroundColor());
+
+ if (vsp.kind() != VSpace::LENGTH && vsp.kind() != VSpace::VFILL )
+ return size;
// top arrow
p.pain->line(leftx, ty1, midx, ty2, LColor::added_space);
