Lars Gullik Bjønnes wrote:
>
> The fast solution that will not require any code changes outside the
> gui is to add a "Reset to Defaults" button for now. Later, 1.4.0cvs, a
> real "Default" button could be added, besides it is nice to know what
> the default is as well.

I don't think this is doable, without having the paragraph telling the
dialog what its original default is or was. Once I change the alignment,
there seem to be no way to find out what is/was the paragraph's default.
That information is not stored anywhere now, and the dialog itself can't
keep track of each paragraph's original default alignment.

So I think, we either leave as it is (without mentioning any default stuff),
or go for the code rewrite.

By the way, I have a large patch to a steadily growing number of
Xforms dialogs. Present snapshot is:

  FormDocument.C             |    6
  FormFloat.C                |  236 ++++++++++----------
  FormFloat.h                |    4
  FormGraphics.h             |    1
  FormParagraph.C            |  200 ++++++++---------
  FormParagraph.h            |    4
  FormPrint.C                |   28 +-
  FormSearch.C               |   40 ++-
  RadioButtonGroup.C         |   20 +
  RadioButtonGroup.h         |   21 -

  forms/form_citation.fd     |   30 +-
  forms/form_document.fd     |  456 +++++++++++++++++++--------------------
  forms/form_float.fd        |  190 ++++++++++------
  forms/form_graphics.fd     |   46 +--
  forms/form_paragraph.fd    |  523 ++++++++++++++++++++-------------------------
  forms/form_print.fd        |   16 -
  forms/form_ref.fd          |   32 +-
  forms/form_search.fd       |  117 ++++------
  forms/form_spellchecker.fd |   74 ++++--
  forms/form_texinfo.fd      |    4


When would be the right time to shift this into CVS? 1.3.1 or 1.4.0?


> PS. Your lines are a bit long, you should make them about 5 chars
> shorter to make it easier to quote you without going over 80 chars.

Who is limiting you to 80 chars wide lines?
Are you using Windows....??? ;)

Rob.

Reply via email to