John Levon wrote:
> On Fri, Sep 06, 2002 at 11:59:04AM +0900, R. Lahaye wrote:
> 
>>Attached.
>>Rob.
> 
> I'm not applying this in its current state :
> 
> 1. Tooltips do not have full stops
> 2. "str = _("Go to selected reference or go back");
> 
>       Not good; you should switch tooltip depending up on what it will
> actually do

Reusing "tooltips().init()" for a second time on a widget is not working.
Problably a buggy implementation of tooltips. The present patch has the code
to switch the tooltip text, but it's not effective.

I realized that by switching the button's text, also the shortcut needs to
be "revived" along with "re"-showing the button. That's also included now;
the whole switch is bundled in a single function "switch_go_button()".

> 3. Not sure about the "Go to" change actually.

Neither am I, but it's not that bad either, is it?
I actually got the naming form Qt :).

> 4. Remember, that these classes
> 
>       Bad english. Lose the comma.

Done.

> 5. Full path is needed to view the contents of a file.
> 
>       Please don't document bugs in tooltips. Fix the bug instead.
> 
> (I know you only moved these last two, but ...)

Done; I mean, the tooltip does not comment the bug anymore; the bug is still
there though :(. But, eh, is it really a bug? What if same filenames appear in
different directories; without the full path the choice could to be ambiguous,
but of course the full path is internally known! I agree the way it works now
is not nice.

> 6. Why has bibitem Close acquired a return arrow ?

Fixed.
This was a result of yet another bug in fdesign.

> 7. I'm not entirely sure the visual assocation of the spellchecker is a
> good idea. It looks like the 3 buttons operate on the replacements
> list... (but "Replace" is good)

New layout better?

Cheers,
Rob.

Attachment: BetterDialogs.diff.gz
Description: application/gzip

Reply via email to