Hi,

Attached is the patch that implements the new layout for the graphics dialog
with xforms. Two files in the Qt directory have been modified, only to keep
Qt compiling; the Qt Graphics dialog itself needs an update similar to the
xforms version of the dialog. John, can you give that a shot?

Few remarks:

1) Now a new graphics inset will always open the dialog in the file-tab,
    irrespectively of what tab was active before.

2) Only non-default values for the inset keywords are saved to the lyx file.
    See development/FORMAT for some more info.
    Do we need to push up the format version?

3) What is this strange setting of defaultUnit in FormGraphics:
            if (lyxrc.default_papersize < 3) defaultUnit = "in";
    (? what is this magic "3" ?).

4) insetgraphics.C::InsetGraphics::readFigInset()
    I commented out the keywords that do not exist anymore, but I
    don't know if I have done the right thing here (and in general
    in this file). Things seem to work here at my side, though.

5) Please test and check the backward compatibility for "reasonable" cases.

...and apply.

Cheers,
Rob.

Attachment: NewGraphicsDialog.diff.gz
Description: application/gzip

Reply via email to