On Friday 16 August 2002 9:02 pm, Martin Vermeer wrote:
> Sorry, just found out that posting to gmane with lynx while not
> remembering how to attach a file to the message is not a good idea :-(
>
> Here come the patches and adds. Good luck.

Before someone applies this, can they alter Paragraph::shortTitleInset() so 
that it's not a Paragraph method, but is a namesapce anon function in 
paragraph.C. There's no need to polute the paragraph.h header file.

This is all in short1.diff:

namespace anon {

InsetShortTitle * shortTitleInset(Paragraph const & par)
{
        // Find the entry.
        InsetList::iterator it = par.insetlist.begin();
        InsetList::iterator end = par.insetlist.end();
        for (; it != end; ++it) {
                Inset * ins = it.getInset();
                if (ins->lyxCode() == Inset::SHORTTITLE_CODE) {
                        return static_cast<InsetShortTitle *>(ins);
                }
        }
        return 0;
}

} // namespace anon

and in the very next block of code move 
+       InsetShortTitle * it = shortTitleInset();
inside the 
        case LATEX_COMMAND:
switch

+               if (style->latexparam() == "void") {
+                       InsetShortTitle * it = shortTitleInset(*this);
+                       if (it != 0)
+                               it->latexOptionals(buf, os, false, false);
+               }

Apart from that this patch looks GOOD (IMO). Can't comment on short2.diff.

Angus

Reply via email to