Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >>>>>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >>>>>>>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: >>> | Lars> | Lars> This reduces binary size a tiny bit, and should remove | Lars> the | Lars> LyXTextClass::operator[]() overhead. >>> | Lars> | Lars> If I get no objections this will go in soonish. >>> | Lars> | This patch is certainly a good idea, but it also means that we | Lars> have no | chance to avoid restarting lyx after reconfigure when | Lars> a file is | loaded. > | Lars> Hmm... why is that? (and what do reconfigure have to do with | Lars> this?) > | Because we would need to re-read the textclasses (I think) and this | would invalidate the pointers. Am I wrong?
But we are not doing that now anyway... | Lars> | Apart from that, LyXLayout_ptr is certainly an ugly name. > | Lars> Give me a better name and I will change it. > | Is it really necessary to gain access to the boost shared_pointer? Perhaps not... eh yes. You are not allowed to keep a LyXLayout*, or a LyXLayout&, both can be deleted under you and result in a crash. -- Lgb