>>>>> "Andrew" == Andrew Zabolotny <[EMAIL PROTECTED]> writes:

Andrew> Hello! I would like to tell you that Cyrillic languages do not
Andrew> work with the 1.2.0 release. However, the needed fixes are
Andrew> quite small, so I will attach them to this letter. 

Hello Andrew, and thanks for the fixes. First, I'd like to point out
that we received before 1.2.0 release another set of fixes from Vitaly
Lipatov and that it would probably be nice to merge them together.
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg37713.html

Andrew> Also I did some fixes which you may or may not like, so I'll
Andrew> explain them here:

Andrew> - First, I've added the XK_KP_XXX arrow keys as aliases to
Andrew> XK_XXX keys in some places (for example, XK_KP_Enter should
Andrew> work same way as XK_Enter in dialog boxes), XK_KP_Up/Down same
Andrew> as XK_Up/Down in dropdown listboxes, comboboxes, minibuffer.

Note that the XK_KP_xxx #defines may not exist everywhere (especially
in X11R5 or proprietary versions of X11). Therefore, I cannot accept
to apply this part of the patch as it is. Maybe guarding these things
with #ifdef would be better.

Andrew> - Second, I've added Greek and Cyrillic letter support in
Andrew> kbmap.C function getiso() (which is a mess anyway :-( - I
Andrew> think it would be much better to use XLookupString or
Andrew> something like it instead).

This part looks reasonable.

Andrew> - Third, I've added two files cyrkeys.bind and greekkeys.bind
Andrew> which list the Cyrillic and Greek symbols from
Andrew> include/X11/xksymdef.h as "self-insert".

This is a part that I would like to see merged with Vitaly's patch/

Andrew> - Fourth, I've added the .cdef files for 5 encodings used with
Andrew> Cyrillic letters (although they are plain 1:1 mappings, they
Andrew> could be a empty file as well, if I understand everything
Andrew> correctly - but if they are missing, LyX barfs at startup).

I am not sure anymore when these files are useful :) Anyway, they
cannot hurt.

Andrew> - Also I have included an addon for cua.bind which makes the
Andrew> KP_ keys behave same as their counterparts on the arrow
Andrew> keypad.

I do not think that I agree with this part:

# Numeric keypad (if Shift+KP_XXX switches to numeric state)
\bind "S-KP_6"                  "forward-select"
\bind "S-KP_4"                  "backward-select"
\bind "S-KP_8"                  "up-select"
\bind "S-KP_2"                  "down-select"
\bind "S-C-KP_6"                "word-forward-select"
\bind "S-C-KP_4"                "word-backward-select"
[...]

If the key is KP_6, it is KP_6... It seems to me that KDE apps, for
example, do the same. We should not try to be too smart.

JMarc

Reply via email to