John Levon wrote: > Just some more nit picky comments ...
yes, there are a lot of such experts here ... >> Item "LyX Document...|X" "file-insert" >> Item "Ascii as Lines...|L" "file-insert-ascii" >> Item "Ascii as Paragraphs...|P" "file-insert-ascii-para" >>+ Separator >>+ Item "Sourcecode formatted|S" "listing-insert" >> > > I would prefer "Source listing ..." (note the ellipsis) > > I'm also not happy about the extension of a menu that is too large > already, but I don't have a good suggestion for that yet. Certainly it > does not deserve its own section: place it below Graphics... perhaps. I'm inserting a _file_ >>+// if (!packageAvailable("listings")) >>+// Alert::alert(_("Sorry, but package listings is not installed\n"), >>+// _("try to get it from http://www.ctan.org")); >>+// else >> > > You hit my pet peeve. From now on I will be naming and shaming people > who comment out code without giving a reason in the source file ... feel free ... >>+ { LFUN_INSERT_LISTING, "listing-insert", // Herbert >2001-10-01 >>+ N_("Inserts formatted sourcecode"), Noop }, >> > > I'd prefer "Insert formatted source code" ok > Can we not use the new-style header agreed upon, please : sure > If you can update the patch for the new controller train wreck stuff > I'll try it out too ... no, I will never update any of my "I don't know how many" new features which I send to the list and which _all_ went into /dev/null, except the "TeX Information" one ... Herbert -- http://www.lyx.org/help/