Just some more nit picky comments ...
On Fri, May 24, 2002 at 05:09:38PM +0200, Herbert Voss wrote:
> Item "LyX Document...|X" "file-insert"
> Item "Ascii as Lines...|L" "file-insert-ascii"
> Item "Ascii as Paragraphs...|P" "file-insert-ascii-para"
> + Separator
> + Item "Sourcecode formatted|S" "listing-insert"
I would prefer "Source listing ..." (note the ellipsis)
I'm also not happy about the extension of a menu that is too large
already, but I don't have a good suggestion for that yet. Certainly it
does not deserve its own section: place it below Graphics... perhaps.
> + case LFUN_INSERT_LISTING:
> + {
> +// if (!packageAvailable("listings"))
> +// Alert::alert(_("Sorry, but package listings is not installed\n"),
> +// _("try to get it from http://www.ctan.org";));
> +// else
You hit my pet peeve. From now on I will be naming and shaming people
who comment out code without giving a reason in the source file ...
Well, naming anyway :)
> + { LFUN_INSERT_LISTING, "listing-insert", // Herbert
>2001-10-01
> + N_("Inserts formatted sourcecode"), Noop },
I'd prefer "Insert formatted source code"
> +// -*- C++ -*-
> +/* This file is part of
> + * ======================================================
> + *
> + * LyX, The Document Processor
> + *
> + * Copyright 2001 The LyX Team.
> + *
> + * ======================================================
> + *
> + * \file ControlListing.h
> + * \author Herbert Voss <[EMAIL PROTECTED]> 2001-11-01
> + */
Can we not use the new-style header agreed upon, please :
/**
* \file blah.h
* Copyright 2001 the LyX Team
* Read the file COPYING
*
* \author John Levon
*/
Cuts down on chatter..
> + ///
> + string const checkFrame(string const & in_frame);
> + ///
> + string const checkRound(string const & in_frame);
ho hum, no comment and it's less than obvious what they might mean ...
> + return "SOURCE code";
Any reason to SHOUT here ?
If you can update the patch for the new controller train wreck stuff
I'll try it out too ...
regards
john
--
"Do you mean to tell me that "The Prince" is not the set textbook for CS1072
Professional Issues ? What on earth do you learn in that course ?"
- David Lester
