Angus Leeming <[EMAIL PROTECTED]> writes:

| Well I can't make much sense of the title and there's no explanation attached 
| to the patch. WIP?
>
>>From what I can see:
>
| * You pass a ButtonController to the ControlButtons c-tor. 
| Seems sensible.

Likely that it will change a bit.

| * You have commented out every single call to view() by any controller.
| Why? What are you trying to do?

I have not found the way to get to the view from the controller yet.

| * You have #included the .tmpl instantiations in their reapective header 
| files.
| Why? Is this a "let's get it working first" type of change?

No, it is imho the right thing to do.
(while we wait for export)

| * The form_xxx.h files are still #included by Dialogs.C. Try and get rid of 
| them; they are only there because the old boost::scoped_ptr wanted them.

correct, and I belive they are still needed.

| Angus
>
| ps. Some words to go with the patch would be good next time ;-)

There were words.... somthing deleted them...

In those words I wondered how the communication between Controller and
View is supposed to be.

-- 
        Lgb

Reply via email to