On Tuesday 19 March 2002 9:57 am, Juergen Vigna wrote:
> On 18-Mar-2002 Angus Leeming wrote:
> > Why do insetexternal and insetgraphics set Inset::id_. Isn't this
> > variable used only by the text insets?
>
> Every inset has it's id! It may not be used but it should have one, just
> in case I would have to look it up. And they also should have the
> posibility to create an inset with the same ID (see clone()), but as you
> said for now this is not really necessary for non text insets.
Thanks. Jürgen. My question could really be rephrased as:
why do insetgraphics and insetexternal set this explicitly in their "copy"
c-tors (well when clone is invoked), rather than by passing this down to the
Inset c-tor to deal with?
In fact, insetgraphics does indeed call the Inset c-tor, so the code setting
id_ there was redundant and I've removed it.
However, insetexternal does not call a c-tor from clone but instead sets
everything itself. I think that this is bad and would prefer it to have a
c-tor also that is called from clone.
Angus
