>>>>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:

Lars> Martin Vermeer <[EMAIL PROTECTED]> writes: | lyxlayout.C: In
Lars> method `const class string & LyXLayout::name() const': |
Lars> lyxlayout.C:740: warning: returning reference to temporary |
Lars> lyxlayout.C: In method `const class string &
Lars> LyXLayout::obsoleted_by() const': | lyxlayout.C:752: warning:
Lars> returning reference to temporary

Lars> Fixing these fixed the problem.

Lars> I have now a patch that apperars to be working, but I have not
Lars> tested switching layout<->layout, reading nonexistant layout
Lars> etc.

Basically, I like what I see. Probablt all the explicit calls to
textclasslist should be encapsulatead in some 
  TextClass & BufferParam::getTClass()
and maybe also
  TextClass & Buffer::getTClass()
  
This would make code more readable and avoid including useless
headers. 
Lars> The pach has been cleaned up a bit and is closer to ready for
Lars> inclusion.

Yes.

JMarc

Reply via email to