On Mon, 28 Jan 2002, Juergen Spitzmueller wrote: > Herbert Voss wrote: > > I finished the graphic inset, the diff is attached. Images of > > the guis are here: > > Herbert, I have played a little bit with your patch. Here are some > comments (this time not so nitpicking, I hope).
:-) > - Suggestion: I guess you will leave the "Display in LyX"-Option in > Preferences as a general possibility? If yes, I would suggest to add a > radio "Default" to the graphics dialog, which is enabled by default and > takes the display settings from Preferences. I'll think about it > - You should probably delete the unsigned_float_filters from width and > height (FormGraphics.C: 116-117) to allow the user to insert > gluelengths like in the other fields (btw: I have added filters which > spit out warnings if the input is nonsense in the other dialogs. > Perhaps you will want to add a text_info field and these filters too? > See tabular, paragraph and document dialogs as examples). gluelength are not possible here, make no sense and are not allowed in latex > - In "Extras", the "Origin" choice is set to an Empty value by default. > Is this intended (or shouldn't it be "default")? yes, should be default. but it's a bit difficult, because there is no default, you have an origin or not. Hebrert
