Herbert Voss wrote: > I finished the graphic inset, the diff is attached. Images of > the guis are here:
Herbert, I have played a little bit with your patch. Here are some comments (this time not so nitpicking, I hope). First: I really like it :-) - Suggestion: I guess you will leave the "Display in LyX"-Option in Preferences as a general possibility? If yes, I would suggest to add a radio "Default" to the graphics dialog, which is enabled by default and takes the display settings from Preferences. - You should probably delete the unsigned_float_filters from width and height (FormGraphics.C: 116-117) to allow the user to insert gluelengths like in the other fields (btw: I have added filters which spit out warnings if the input is nonsense in the other dialogs. Perhaps you will want to add a text_info field and these filters too? See tabular, paragraph and document dialogs as examples). - In "Extras", the "Origin" choice is set to an Empty value by default. Is this intended (or shouldn't it be "default")? Apart from this minor things, all worked very well for me. Greets, Juergen.
